As some of you already know, I’m porting CyanogenMod for the FP2 with some other great people like @NicoM, @Arvil and @z3ntu (plus others).
While doing so, rewriting the device configs, I stumbled upon the below lines:
TARGET_USES_QCA_NFC := other
# NFC packages
ifeq ($(TARGET_USES_QCA_NFC),true)
NFC_D := true
ifeq ($(NFC_D), true)
PRODUCT_PACKAGES += \
libnfcD-nci \
libnfcD_nci_jni \
nfc_nci.msm8974 \
NfcDNci \
Tag \
com.android.nfc_extras \
com.android.nfc.helper
else
PRODUCT_PACKAGES += \
libnfc-nci \
libnfc_nci_jni \
nfc_nci.msm8974 \
NfcNci \
Tag \
com.android.nfc_extras
endif
# file that declares the MIFARE NFC constant
# Commands to migrate prefs from com.android.nfc3 to com.android.nfc
# NFC access control + feature files + configuration
PRODUCT_COPY_FILES += \
frameworks/native/data/etc/com.nxp.mifare.xml:system/etc/permissions/com.nxp.mifare.xml \
frameworks/native/data/etc/com.android.nfc_extras.xml:system/etc/permissions/com.android.nfc_extras.xml \
frameworks/native/data/etc/android.hardware.nfc.xml:system/etc/permissions/android.hardware.nfc.xml
# Enable NFC Forum testing by temporarily changing the PRODUCT_BOOT_JARS
# line has to be in sync with build/target/product/core_base.mk
endif
Questions flow immediately:
- Why are those files configuring NFC while the FP2 has no hardware support for this?
- Could this be related to the extreme battery consumption some users suffer from?
- Are they there for some reason, or are just CodeAurora remainders? If the former, should we include this configs when porting?
Let’s see if someone from the developers team (@jftr, @dirkv) can take some look here or tell their coworkers.